[Do not merge] - Dataview perf improvements poc#4
Closed
michaelolo24 wants to merge 1 commit intolgestc:default_data_view_initfrom
Closed
[Do not merge] - Dataview perf improvements poc#4michaelolo24 wants to merge 1 commit intolgestc:default_data_view_initfrom
michaelolo24 wants to merge 1 commit intolgestc:default_data_view_initfrom
Conversation
michaelolo24
commented
Jun 10, 2025
| </DiscoverInTimelineContextProvider> | ||
| </UpsellingProvider> | ||
| </CellActionsProvider> | ||
| <ReactQueryDevtools initialIsOpen={false} /> |
Author
There was a problem hiding this comment.
Needs to be here to account for providers above the cases context
michaelolo24
commented
Jun 10, 2025
| <Route path="/"> | ||
| <CasesContext owner={[APP_ID]} permissions={userCasesPermissions}> | ||
| <HomePage>{children}</HomePage> | ||
| <ReactQueryClientProvider> |
Author
There was a problem hiding this comment.
Cases context has it's own queryClient which we need to re-override, but need to test this behavior. This is primarily useful just for our testing purposes
9ae1546 to
95f4cd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test with minimum 300k+ fields in the index mapping and documents containing fields populated to that extent
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.